Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: added exclude_defaults=False for profiler and deploy on airflow-apis #16734

Merged
merged 3 commits into from
Jun 21, 2024
Merged

MINOR: added exclude_defaults=False for profiler and deploy on airflow-apis #16734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f1666d8
added exclude_defaults=False for profiler and deploy on airflow-apis
IceS2 Jun 20, 2024
9bdfbc2
fix checkstyle
IceS2 Jun 20, 2024
1f6250a
Fix model_dump_json for all pipelines
IceS2 Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion openmetadata-airflow-apis/openmetadata_managed_apis/operations/deploy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,9 @@ def store_airflow_pipeline_config(

logger.info(f"Saving file to {dag_config_file_path}")
with open(dag_config_file_path, "w") as outfile:
outfile.write(self.ingestion_pipeline.model_dump_json())
outfile.write(
self.ingestion_pipeline.model_dump_json(exclude_defaults=False)
)

return {"workflow_config_file": str(dag_config_file_path)}

Expand Down
2 changes: 1 addition & 1 deletion openmetadata-airflow-apis/openmetadata_managed_apis/workflows/ingestion/application.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def application_workflow(workflow_config: OpenMetadataApplicationConfig):

set_operator_logger(workflow_config)

config = json.loads(workflow_config.model_dump_json())
config = json.loads(workflow_config.model_dump_json(exclude_defaults=False))
workflow = ApplicationWorkflow.create(config)

workflow.execute()
Expand Down
2 changes: 1 addition & 1 deletion openmetadata-airflow-apis/openmetadata_managed_apis/workflows/ingestion/data_insight.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def data_insight_workflow(workflow_config: OpenMetadataWorkflowConfig):
"""
set_operator_logger(workflow_config)

config = json.loads(workflow_config.model_dump_json())
config = json.loads(workflow_config.model_dump_json(exclude_defaults=False))
workflow = DataInsightWorkflow.create(config)

workflow.execute()
Expand Down
2 changes: 1 addition & 1 deletion openmetadata-airflow-apis/openmetadata_managed_apis/workflows/ingestion/profiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def profiler_workflow(workflow_config: OpenMetadataWorkflowConfig):

set_operator_logger(workflow_config)

config = json.loads(workflow_config.model_dump_json())
config = json.loads(workflow_config.model_dump_json(exclude_defaults=False))
workflow = ProfilerWorkflow.create(config)

workflow.execute()
Expand Down
2 changes: 1 addition & 1 deletion openmetadata-airflow-apis/openmetadata_managed_apis/workflows/ingestion/test_suite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def test_suite_workflow(workflow_config: OpenMetadataWorkflowConfig):

set_operator_logger(workflow_config)

config = json.loads(workflow_config.model_dump_json())
config = json.loads(workflow_config.model_dump_json(exclude_defaults=False))
workflow = TestSuiteWorkflow.create(config)

workflow.execute()
Expand Down
2 changes: 1 addition & 1 deletion openmetadata-airflow-apis/openmetadata_managed_apis/workflows/ingestion/usage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def usage_workflow(workflow_config: OpenMetadataWorkflowConfig):

set_operator_logger(workflow_config)

config = json.loads(workflow_config.model_dump_json())
config = json.loads(workflow_config.model_dump_json(exclude_defaults=False))
workflow = UsageWorkflow.create(config)

workflow.execute()
Expand Down
Loading