Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue-16973] Fix Issue in Import TableCsv #16974

Merged
merged 3 commits into from
Jul 16, 2024
Merged

[Issue-16973] Fix Issue in Import TableCsv #16974

merged 3 commits into from
Jul 16, 2024

Conversation

mohityadav766
Copy link
Contributor

Describe your changes:

  • This PR fixes the backend issue on validation in importing a CSV
  • Pending Fix from the UI side for "" on empty cells

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@mohityadav766 mohityadav766 requested a review from a team as a code owner July 9, 2024 15:08
@mohityadav766 mohityadav766 self-assigned this Jul 9, 2024
@github-actions github-actions bot added backend safe to test Add this label to run secure Github workflows on PRs labels Jul 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Phylum OSS Supply Chain Risk Analysis - SUCCESS

The Phylum risk analysis is complete and has passed the active policy.

View this project in the Phylum UI

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Phylum OSS Supply Chain Risk Analysis - SUCCESS

The Phylum risk analysis is complete and has passed the active policy.

View this project in the Phylum UI

@github-actions GitHub Actions
Copy link
Contributor

Phylum OSS Supply Chain Risk Analysis - SUCCESS

The Phylum risk analysis is complete and has passed the active policy.

View this project in the Phylum UI

@github-actions GitHub Actions
Copy link
Contributor

Phylum OSS Supply Chain Risk Analysis - SUCCESS

The Phylum risk analysis is complete and has passed the active policy.

View this project in the Phylum UI

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 10, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

TeddyCr
TeddyCr reviewed Jul 15, 2024
View reviewed changes
Copy link
Contributor

@TeddyCr TeddyCr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 @mohityadav766 are we able to add a test to validate this logic works as expected and that we do not introduce regression in the future 😊

@mohityadav766
Copy link
Contributor Author

LGTM 🚀 @mohityadav766 are we able to add a test to validate this logic works as expected and that we do not introduce regression in the future 😊

hi @TeddyCr , thanks for reviewing, from backend perspective it was all good there were empty cell issue from the UI , maybe we should cover those with cypress cc @chirag-madlani

@mohityadav766
Copy link
Contributor Author

mohityadav766 commented Jul 16, 2024 •
edited
Loading

merging this , @chirag-madlani let's add cypress via another PR on collate side

@mohityadav766 mohityadav766 merged commit 5a95983 into main Jul 16, 2024
17 of 18 checks passed
@mohityadav766 mohityadav766 deleted the fix-imports branch July 16, 2024 13:17
mohityadav766 added a commit that referenced this pull request Jul 19, 2024
@mohityadav766
Fix Issue in Import Table (#16974)
f02c4ce 
(cherry picked from commit 5a95983)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TeddyCr TeddyCr TeddyCr left review comments

@harshach harshach Awaiting requested review from harshach

Assignees

@mohityadav766 mohityadav766

Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mohityadav766 @TeddyCr