Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alert bar component #17230

Draft
wants to merge 103 commits into
base: main
Choose a base branch
from
Draft

Add alert bar component #17230

wants to merge 103 commits into from
+629 −313

Conversation

sweta1308
Copy link
Contributor

@sweta1308 sweta1308 commented Jul 30, 2024 •
edited by chirag-madlani
Loading

Describe your changes:

Fixes

I worked on creating a component to show the alerts.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
image image image image image

@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Sachin-chaurasiya
Sachin-chaurasiya reviewed Jul 30, 2024
View reviewed changes
Copy link
Member

@Sachin-chaurasiya Sachin-chaurasiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, thanks

openmetadata-ui/src/main/resources/ui/src/pages/MyDataPage/MyDataPage.component.tsx Outdated Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/src/assets/svg/warning-icon.svg Outdated Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/src/components/AlertBar/AlertBar.interface.ts Outdated Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/src/components/AlertBar/AlertBar.tsx Outdated Show resolved Hide resolved
@Sachin-chaurasiya Sachin-chaurasiya added the safe to test Add this label to run secure Github workflows on PRs label Jul 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

Phylum OSS Supply Chain Risk Analysis - SUCCESS

The Phylum risk analysis is complete and has passed the active policy.

View this project in the Phylum UI

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 30, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
 63.55% (39787/62607) 40.16% (15783/39305) 42.3% (4722/11162)

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 19, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya left review comments

@chirag-madlani chirag-madlani chirag-madlani left review comments

@ShaileshParmar11 ShaileshParmar11 Awaiting requested review from ShaileshParmar11 ShaileshParmar11 is a code owner

@karanh37 karanh37 Awaiting requested review from karanh37 karanh37 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
e2e:Observability e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sweta1308 @chirag-madlani @Sachin-chaurasiya @Ashish8689