Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix patch permissions #17271

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Fix patch permissions #17271

merged 2 commits into from
Aug 2, 2024

Conversation

harshach
Copy link
Collaborator

@harshach harshach commented Aug 2, 2024

Describe your changes:

Patch operations must be evaluated in hierarchical order.
For ex: if a User is adding a owner or tag they can be
/owners/0/displayname, /owners/0/fullyQualifiedName or /messageScheam/schemaFields/order/tags
in first case we should look up owners and return the operation immediately if try to match operation with the path
then we will get user might not have permissions edit_display_name

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

github-actions bot commented Aug 2, 2024

Phylum OSS Supply Chain Risk Analysis - FAILED

This repository analyzes the risk of new dependencies. An
administrator of this repository has set requirements via Phylum policy.

If you see this comment, one or more dependencies have failed Phylum's risk analysis.

Package: braces@2.3.2 failed.

braces@2.3.2 is vulnerable to Uncontrolled resource consumption

Risk Domain: Software Vulnerability
Risk Level: high

Reason: Critical or High software vulnerability

Package: braces@3.0.2 failed.

braces@3.0.2 is vulnerable to Uncontrolled resource consumption

Risk Domain: Software Vulnerability
Risk Level: high

Reason: Critical or High software vulnerability

View this project in the Phylum UI

Copy link

sonarcloud bot commented Aug 2, 2024

@harshach harshach merged commit 34b756a into main Aug 2, 2024
17 of 19 checks passed
@harshach harshach deleted the fix_patch_permissions branch August 2, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant