Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated oracle to use DBA_ tables #17274

Merged
merged 9 commits into from
Aug 10, 2024
Merged

Updated oracle to use DBA_ tables #17274

merged 9 commits into from
Aug 10, 2024

Conversation

IceS2
Copy link
Contributor

@IceS2 IceS2 commented Aug 2, 2024

Describe your changes:

Based on discussions we decided to go back to using DBA tables for Oracle.
This PR aims to tackle that plus fixing some missing queries that were still using ALL

Type of change:

  • Improvement

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

github-actions bot commented Aug 2, 2024

Phylum OSS Supply Chain Risk Analysis - FAILED

This repository analyzes the risk of new dependencies. An
administrator of this repository has set requirements via Phylum policy.

If you see this comment, one or more dependencies have failed Phylum's risk analysis.

Package: braces@2.3.2 failed.

braces@2.3.2 is vulnerable to Uncontrolled resource consumption

Risk Domain: Software Vulnerability
Risk Level: high

Reason: Critical or High software vulnerability

Package: braces@3.0.2 failed.

braces@3.0.2 is vulnerable to Uncontrolled resource consumption

Risk Domain: Software Vulnerability
Risk Level: high

Reason: Critical or High software vulnerability

View this project in the Phylum UI

Copy link
Contributor

github-actions bot commented Aug 2, 2024

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Copy link
Contributor

github-actions bot commented Aug 5, 2024

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Copy link
Contributor

github-actions bot commented Aug 5, 2024

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Copy link
Collaborator

@pmbrull pmbrull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add the docs as well with the updated requirements? that's been the part we missed in the past

@ayush-shah
Copy link
Member

can we add the docs as well with the updated requirements? that's been the part we missed in the past

Yes, will be adding the same today, Thanks.

Copy link

sonarcloud bot commented Aug 8, 2024

Comment on lines +71 to +87
-- If you are using a role and do not want to specify a specific table, but any
GRANT SELECT ANY TABLE TO new_role;

-- If you are not using a role, but directly giving permission to the user and do not want to specify a specific table, but any
GRANT SELECT ANY TABLE TO my_user;

-- if you are using role
GRANT SELECT ON ADMIN.EXAMPLE_TABLE TO new_role;

-- if you are not using role, but directly giving permission to the user
GRANT SELECT ON ADMIN.EXAMPLE_TABLE TO my_user;

-- if you are using role
GRANT SELECT ON {schema}.{table} TO new_role;

-- if you are not using role, but directly giving permission to the user
GRANT SELECT ON {schema}.{table} TO my_user;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed for the Profiler and Data Quality Tests.

Particularly I wouldn't intertwine ROLE and USER. I'd do everything for the user and then explain that they could rely on a role for that if you want, explaining how to create the role and saying that all the grants should be done at role level

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IceS2 i have added the comment in 1.5.x that it is needed for Profiler and DQ as a note just above it.
Role and User examples were given with a comment so that if there are usecases of someone for either, the above would cater both the usecases.

@ayush-shah ayush-shah merged commit e5a7cff into main Aug 10, 2024
32 of 34 checks passed
@ayush-shah ayush-shah deleted the oracle-improvements branch August 10, 2024 11:28
ayush-shah added a commit that referenced this pull request Aug 20, 2024
Co-authored-by: Ayush Shah <ayush@getcollate.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Oracle Stored Procedures Improvement
3 participants