-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated oracle to use DBA_ tables #17274
Conversation
Phylum OSS Supply Chain Risk Analysis - FAILEDThis repository analyzes the risk of new dependencies. An If you see this comment, one or more dependencies have failed Phylum's risk analysis. Package:
|
The Python checkstyle failed. Please run You can install the pre-commit hooks with |
The Python checkstyle failed. Please run You can install the pre-commit hooks with |
71a7bcb
to
36487b3
Compare
The Python checkstyle failed. Please run You can install the pre-commit hooks with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add the docs as well with the updated requirements? that's been the part we missed in the past
Yes, will be adding the same today, Thanks. |
openmetadata-docs/content/v1.5.x-SNAPSHOT/connectors/database/oracle/index.md
Show resolved
Hide resolved
Quality Gate passed for 'open-metadata-ingestion'Issues Measures |
-- If you are using a role and do not want to specify a specific table, but any | ||
GRANT SELECT ANY TABLE TO new_role; | ||
|
||
-- If you are not using a role, but directly giving permission to the user and do not want to specify a specific table, but any | ||
GRANT SELECT ANY TABLE TO my_user; | ||
|
||
-- if you are using role | ||
GRANT SELECT ON ADMIN.EXAMPLE_TABLE TO new_role; | ||
|
||
-- if you are not using role, but directly giving permission to the user | ||
GRANT SELECT ON ADMIN.EXAMPLE_TABLE TO my_user; | ||
|
||
-- if you are using role | ||
GRANT SELECT ON {schema}.{table} TO new_role; | ||
|
||
-- if you are not using role, but directly giving permission to the user | ||
GRANT SELECT ON {schema}.{table} TO my_user; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed for the Profiler and Data Quality Tests.
Particularly I wouldn't intertwine ROLE and USER. I'd do everything for the user and then explain that they could rely on a role for that if you want, explaining how to create the role and saying that all the grants should be done at role level
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@IceS2 i have added the comment in 1.5.x that it is needed for Profiler and DQ as a note just above it.
Role and User examples were given with a comment so that if there are usecases of someone for either, the above would cater both the usecases.
Co-authored-by: Ayush Shah <ayush@getcollate.io>
Describe your changes:
Based on discussions we decided to go back to using
DBA
tables for Oracle.This PR aims to tackle that plus fixing some missing queries that were still using
ALL
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>