Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX - Ingestion Airflow Image constraints #17296

Merged
merged 3 commits into from
Aug 6, 2024
Merged

FIX - Ingestion Airflow Image constraints #17296

merged 3 commits into from
Aug 6, 2024

Conversation

pmbrull
Copy link
Collaborator

@pmbrull pmbrull commented Aug 5, 2024 •
edited
Loading

Describe your changes:

  • Aligned ingestion image constraints to properly use 2.9.1
  • In CI we weren't applying the right constraints
  • Aligned the airflow APIs to work the new Airflow constraints
  • Setuptools yanked the faulty release and we don't need the custom constraint anymore

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Aug 5, 2024
@pmbrull pmbrull changed the title FIX - Ingestion constraints FIX - Ingestion Airflow Image constraints Aug 5, 2024
@pmbrull pmbrull marked this pull request as ready for review August 5, 2024 17:03
@pmbrull pmbrull requested a review from a team as a code owner August 5, 2024 17:03
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 5, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-airflow-apis'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 5, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@pmbrull pmbrull merged commit 4cddee8 into open-metadata:main Aug 6, 2024
22 of 25 checks passed
@pmbrull pmbrull deleted the ingestion-docker-build branch August 6, 2024 04:44
pmbrull added a commit that referenced this pull request Aug 6, 2024
@pmbrull
FIX - Ingestion Airflow Image constraints (#17296)
93e1322 
* FIX - Ingestion constraints

* FIX - Ingestion constraints

* FIX - Ingestion constraints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayush-shah ayush-shah ayush-shah approved these changes

Assignees
No one assigned
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmbrull @ayush-shah