Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: handle "ignored exception" error message when running table diff #17320

Closed
wants to merge 14 commits into from
Closed

MINOR: handle "ignored exception" error message when running table diff #17320

wants to merge 14 commits into from

Conversation

sushi30
Copy link
Contributor

@sushi30 sushi30 commented Aug 6, 2024 •
edited
Loading

Describe your changes:

Uses a custom iterator to close the table diff and catch the sneaky KeyError

Exception ignored in: <generator object TableDiffer._diff_tables_wrapper at 0xffff5c123f40>
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/data_diff/diff_tables.py", line 244, in _diff_tables_wrapper
    info_tree.aggregate_info()
  File "/usr/local/lib/python3.10/site-packages/data_diff/info_tree.py", line 62, in aggregate_info
    self.info.update_from_children(c.info for c in self.children)
  File "/usr/local/lib/python3.10/site-packages/data_diff/info_tree.py", line 41, in update_from_children
    2: sum(c.rowcounts[2] for c in child_infos if c.rowcounts),
  File "/usr/local/lib/python3.10/site-packages/data_diff/info_tree.py", line 41, in <genexpr>
    2: sum(c.rowcounts[2] for c in child_infos if c.rowcounts),
KeyError: 2

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

github-actions bot and others added 9 commits August 2, 2024 16:18
@github-actions
chore(release): Prepare Branch for 1.5.0
f06595e
@github-actions
chore(release): Prepare Branch for 1.5.0-rc1
0799336
@Ashish8689 @chirag-madlani @harshach
ISSUE : fix teams page breaking issue (#17268)
7319c90 
* fix teams page breaking issue

* minor changes

* unpushed file

---------

Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
@harshach
Minor: Fix Policy rule migration due to owner -> owners (#17285)
c531671
@ShaileshParmar11 @IceS2
Minor: fixed failing query entity cypress (#17261)
5116fed 
* Minor: fixed failing query entity cypress

* fixed failing cypress
@ayush-shah @IceS2
Minor: Remove 'owner' field from JSON in various entities (#17290)
9819d0f 
* Remove owner field from json in various entities

* Add Psql migrations for owner

* Modify operator type for query

* chore: Update table_entity JSON structure to include dataModel owners
@pmbrull
FIX - Ingestion Airflow Image constraints (#17296)
93e1322 
* FIX - Ingestion constraints

* FIX - Ingestion constraints

* FIX - Ingestion constraints
@pmbrull
MINOR - Bump openmetadata-managed-apis RC1 version
d21f812
@sushi30
added comment for table diff ignored exception
19f8265
@github-actions github-actions bot added e2e:DataAssets e2e:Settings UI UI specific issues Ingestion backend devops safe to test Add this label to run secure Github workflows on PRs and removed e2e:DataAssets e2e:Settings labels Aug 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
 64.98% (36825/56667) 41.65% (14607/35073) 43.73% (4473/10229)

@sushi30 sushi30 changed the title MINOR: table diff comment ignored exception comment MINOR: handle "ignored exception" error message when running table diff Aug 6, 2024
@sushi30 sushi30 closed this Aug 6, 2024
@sushi30 sushi30 deleted the minor/table-diff-comment branch August 6, 2024 16:02
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 6, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-airflow-apis'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 6, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 6, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
76.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akash-jain-10 akash-jain-10 Awaiting requested review from akash-jain-10 akash-jain-10 is a code owner

@harshach harshach Awaiting requested review from harshach harshach is a code owner

@tutte tutte Awaiting requested review from tutte tutte is a code owner

@ShaileshParmar11 ShaileshParmar11 Awaiting requested review from ShaileshParmar11 ShaileshParmar11 is a code owner

@karanh37 karanh37 Awaiting requested review from karanh37 karanh37 is a code owner

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani chirag-madlani is a code owner

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya Sachin-chaurasiya is a code owner

Assignees
No one assigned
Labels
backend devops Ingestion safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sushi30 @Ashish8689 @harshach @ShaileshParmar11 @ayush-shah @pmbrull