Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: ui improvement #17388

Merged
merged 3 commits into from
Aug 11, 2024
Merged

MINOR: ui improvement #17388

merged 3 commits into from
Aug 11, 2024

Conversation

Ashish8689
Copy link
Contributor

Describe your changes:

  • Fix the long text in tag or glossary tags, used in entity
  • Remove the template field data from the EmailConfigutation Page
  • Fix the overflow scroll to right in Test connection model
  • Hide the AddClassification button in case of no create permission like Glossary

Issue :
image
image
image
image

Fixed :

image image image
Screen.Recording.2024-08-11.at.8.16.05.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

github-actions bot commented Aug 11, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
64.97% (36922/56828) 41.71% (14720/35295) 43.71% (4482/10254)

Copy link

sonarcloud bot commented Aug 11, 2024

Copy link

cypress bot commented Aug 11, 2024



Test summary

11 1 0 19


Run details

Project openmetadata
Status Failed
Commit 2b332c4
Started Aug 11, 2024 4:14 PM
Ended Aug 11, 2024 4:17 PM
Duration 02:38 💡
OS Linux Ubuntu -
Browser Chrome 127

View run in Cypress Cloud ➡️


Failures

cypress/e2e/Pages/Glossary.spec.ts Failed
1 Glossary page should work properly > Create new glossary flow should work properly

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@Ashish8689 Ashish8689 enabled auto-merge (squash) August 11, 2024 16:33
@Ashish8689 Ashish8689 merged commit b497108 into main Aug 11, 2024
15 of 17 checks passed
@Ashish8689 Ashish8689 deleted the ui-fixes-3 branch August 11, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e:Governance e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants