Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): data insight page feedbacks #17390

Merged
merged 6 commits into from
Aug 12, 2024
Merged

fix(ui): data insight page feedbacks #17390

merged 6 commits into from
Aug 12, 2024

Conversation

chirag-madlani
Copy link
Collaborator

@chirag-madlani chirag-madlani commented Aug 11, 2024 •
edited by ulixius9
Loading

Describe your changes:

Fixes

  • Improve advanced search to have the possibility of updating URL or not
  • Improve toastNotificaion assert for Playwright
  • Fix percentage for tier summary card
  • addressed the feedback of skipping the data if count is null

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added UI UI specific issues e2e:Observability e2e:DataAssets safe to test Add this label to run secure Github workflows on PRs labels Aug 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 11, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
 64.97% (36926/56832) 41.71% (14721/35297) 43.72% (4483/10255)

@ulixius9 ulixius9 requested a review from a team as a code owner August 12, 2024 06:48
aniketkatkar97
aniketkatkar97 previously approved these changes Aug 12, 2024
View reviewed changes
ayush-shah
ayush-shah previously approved these changes Aug 12, 2024
View reviewed changes
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 12, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 12, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@chirag-madlani chirag-madlani merged commit 995320a into main Aug 12, 2024
23 of 24 checks passed
@chirag-madlani chirag-madlani deleted the di-feedbacks branch August 12, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshach harshach harshach approved these changes

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 left review comments

@aniketkatkar97 aniketkatkar97 aniketkatkar97 left review comments

@ayush-shah ayush-shah ayush-shah left review comments

@karanh37 karanh37 Awaiting requested review from karanh37 karanh37 is a code owner

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya Sachin-chaurasiya is a code owner

Assignees
No one assigned
Labels
e2e:Observability safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chirag-madlani @harshach @ayush-shah @aniketkatkar97 @ShaileshParmar11 @ulixius9