Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: introduce nox to tun tests in isolated environments #17404

Open
wants to merge 69 commits into
base: main
Choose a base branch
from

Conversation

sushi30
Copy link
Contributor

@sushi30 sushi30 commented Aug 12, 2024

Describe your changes:

Introduce nox to run the test in isolated environments. This is critical to validate our dependencies and plugins are independent of each other (example: the postgres plugin does require boto3)

Manual actions: https://github.com/open-metadata/OpenMetadata/actions/workflows/py-tests.yml?query=branch%3Aadd-tox+event%3Aworkflow_dispatch

Requires

TODO

  • add tests in a docker environment

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@sushi30 sushi30 requested a review from a team as a code owner August 12, 2024 12:03
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Aug 12, 2024
@sushi30 sushi30 marked this pull request as draft August 12, 2024 12:04
Copy link

sonarcloud bot commented Aug 12, 2024

Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@harshach
Copy link
Collaborator

harshach commented Nov 9, 2024

@sushi30 are we still planning on merging it
cc @pmbrull

@sushi30
Copy link
Contributor Author

sushi30 commented Nov 11, 2024

@harshach yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants