Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX - Postgres Python CI #17859

Merged
merged 5 commits into from
Sep 17, 2024
Merged

FIX - Postgres Python CI #17859

merged 5 commits into from
Sep 17, 2024

Conversation

pmbrull
Copy link
Collaborator

@pmbrull pmbrull commented Sep 16, 2024

Describe your changes:

  • Some ingestion tests were relying on the backend's db. We're now using testcontainers to allow tests to be executed when the backend is using postgres instead of mysql
  • we had convert_timestamp_to_milliseconds in sample_data which we'll deprecate by 1.7, there were logs when running it
  • related to GEN-1494

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@pmbrull pmbrull changed the title Fix pg pytests FIX - Postgres Python CI Sep 16, 2024
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Sep 16, 2024
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Copy link

Python CI with PG and OS

Copy link

sonarcloud bot commented Sep 17, 2024

@pmbrull pmbrull merged commit 91ddfcf into open-metadata:main Sep 17, 2024
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants