Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue-13782] Add Search RBAC config option in settings #17866

Closed
wants to merge 22 commits into from

Conversation

mohityadav766
Copy link
Contributor

@mohityadav766 mohityadav766 commented Sep 16, 2024

Describe your changes:

Part of Issue-13782

Screen.Recording.2024-09-24.at.9.10.44.PM.mov

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@mohityadav766
Copy link
Contributor Author

@chirag-madlani can someone take this up from UI we need to a simple setting with a toggle under Settings -> Access Control -> RBAC Search cc @harshach

@chirag-madlani
Copy link
Collaborator

@chirag-madlani can someone take this up from UI we need to a simple setting with a toggle under Settings -> Access Control -> RBAC Search cc @harshach

Having just a toggle in a page will not look good. will check with @Rupchavan here tomorrow

# Conflicts:
#	openmetadata-service/src/main/java/org/openmetadata/service/search/elasticsearch/ElasticSearchClient.java
#	openmetadata-service/src/main/java/org/openmetadata/service/search/opensearch/OpenSearchClient.java
@harshach
Copy link
Collaborator

@chirag-madlani lets addd beta flag around the search rbac setting in UI

# Conflicts:
#	openmetadata-service/src/main/java/org/openmetadata/service/search/security/RBACConditionEvaluator.java
Copy link

sonarcloud bot commented Oct 21, 2024

Copy link

sonarcloud bot commented Oct 21, 2024

@chirag-madlani
Copy link
Collaborator

Duplicate #18338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants