[Issue-13782] Add Search RBAC config option in settings #17866
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
backend
safe to test
|
@chirag-madlani can someone take this up from UI we need to a simple setting with a toggle under Settings -> Access Control -> RBAC Search cc @harshach |
Having just a toggle in a page will not look good. will check with @Rupchavan here tomorrow |
harshach
reviewed
Sep 16, 2024
openmetadata-spec/src/main/resources/json/schema/configuration/rbacSearchConfiguration.json
Outdated
Show resolved
Hide resolved
mohityadav766
had a problem deploying
to
test
GitHub Actions
Failure
mohityadav766
had a problem deploying
to
test
GitHub Actions
Failure
# Conflicts: # openmetadata-service/src/main/java/org/openmetadata/service/search/elasticsearch/ElasticSearchClient.java # openmetadata-service/src/main/java/org/openmetadata/service/search/opensearch/OpenSearchClient.java
mohityadav766
had a problem deploying
to
test
GitHub Actions
Failure
mohityadav766
had a problem deploying
to
test
GitHub Actions
Failure
mohityadav766
had a problem deploying
to
test
GitHub Actions
Failure
chirag-madlani
had a problem deploying
to
test
GitHub Actions
Failure
chirag-madlani
had a problem deploying
to
test
GitHub Actions
Failure
chirag-madlani
had a problem deploying
to
test
GitHub Actions
Failure
chirag-madlani
had a problem deploying
to
test
GitHub Actions
Failure
|
@chirag-madlani lets addd beta flag around the search rbac setting in UI |
# Conflicts: # openmetadata-service/src/main/java/org/openmetadata/service/search/security/RBACConditionEvaluator.java
|
|
|
Duplicate #18338 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Part of Issue-13782
Screen.Recording.2024-09-24.at.9.10.44.PM.mov
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>