Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNIOR: feat(apps): support config file #17872

Merged
merged 10 commits into from
Sep 24, 2024
Merged

MNIOR: feat(apps): support config file #17872

merged 10 commits into from
Sep 24, 2024

Conversation

sushi30
Copy link
Contributor

@sushi30 sushi30 commented Sep 17, 2024

  • added support for app config files
  • removed AppPrivateConfig from the OpenMetadata server configuration

Describe your changes:

Fixes

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

- added support for app config files
- removed AppPrivateConfig from the OpenMetadata server configuration
Copy link

Copy link
Contributor

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Copy link

sonarcloud bot commented Sep 24, 2024

@sushi30 sushi30 merged commit 350e0f7 into main Sep 24, 2024
18 of 19 checks passed
@sushi30 sushi30 deleted the app-config-file branch September 24, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants