GEN-1434: Improvement : Show displayName for database and databaseSchema in explore tree #17876
+239
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonika-shah
added
backend
safe to test
karanh37
requested review from
ShaileshParmar11,
karanh37,
chirag-madlani and
Sachin-chaurasiya
as code owners
Jest test CoverageUI tests summary
|
sushi30
previously approved these changes
Sep 19, 2024
karanh37
changed the title
| super.entityRelationshipReindex(original, updated); | ||
|
|
||
| // Update search indexes of assets and entity on database displayName change | ||
| if (!Objects.equals(original.getDisplayName(), updated.getDisplayName())) { |
There was a problem hiding this comment.
Do we need to do this explicitly, will the updateEntity() in search not take care of this ?
There was a problem hiding this comment.
updateEntity() currents only updates the inherited and propagated fields in children and not other fields of the parent entity
| super.entityRelationshipReindex(original, updated); | ||
|
|
||
| // Update search indexes of assets and entity on databaseSchema displayName change | ||
| if (!Objects.equals(original.getDisplayName(), updated.getDisplayName())) { |
There was a problem hiding this comment.
We are reindexing the whole entity on just displayNameChange, should we just update the disaplayName?
There was a problem hiding this comment.
this improvement will be handled in a different pr, will link the pr once it is ready
mohityadav766
approved these changes
Sep 26, 2024
openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/AdvancedSearch.spec.ts
Show resolved
Hide resolved
aniketkatkar97
approved these changes
Sep 26, 2024
ShaileshParmar11
approved these changes
Sep 26, 2024
chirag-madlani
approved these changes
Sep 26, 2024
|
|
karanh37
pushed a commit
that referenced
this pull request
Sep 27, 2024
…ema in explore tree (#17876) * Show displayName for database and databaseSchema in explore tree * use display name for database and schema * add playwright * resync indexes of dataAssets based on database & databaseSchema displayName change --------- Co-authored-by: karanh37 <karanh37@gmail.com> Co-authored-by: Karan Hotchandani <33024356+karanh37@users.noreply.github.com> (cherry picked from commit a99fbb2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Show displayName for database and databaseSchema in explore tree
Backend changes-
database.displayNameanddatabaseSchema.displayName.keywordon dataAssetScreen.Recording.2024-09-26.at.11.53.25.AM.mov
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>