Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEN 1507 - Implement Origin Entity FQN parms to incident manager listing #17890

Merged
merged 12 commits into from
Sep 18, 2024

Conversation

TeddyCr
Copy link
Contributor

@TeddyCr TeddyCr commented Sep 17, 2024

Describe your changes:

  • Fix filter by test case FQN
  • Added origin entity FQN params to list incidents

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Bug fix

  • I have added a test that covers the exact scenario we are fixing. For complex issues, comment the issue number in the test for future reference.

Improvement

  • I have added tests around the new logic.
  • For connector/ingestion changes: I updated the documentation.

pmbrull
pmbrull previously approved these changes Sep 17, 2024
@TeddyCr TeddyCr enabled auto-merge (squash) September 17, 2024 19:28
harshach
harshach previously approved these changes Sep 17, 2024
Copy link

sonarcloud bot commented Sep 17, 2024

Copy link
Contributor

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
64.31% (37352/58080) 40.96% (14784/36096) 43.07% (4507/10465)

Copy link

sonarcloud bot commented Sep 18, 2024

@TeddyCr TeddyCr merged commit 4331570 into open-metadata:main Sep 18, 2024
19 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data quality Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants