-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix owners patch issue #17900
Merged
Merged
fix owners patch issue #17900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
safe to test
Add this label to run secure Github workflows on PRs
label
Sep 18, 2024
mohityadav766
had a problem deploying
to
test
September 18, 2024 09:07
— with
GitHub Actions
Failure
mohityadav766
had a problem deploying
to
test
September 18, 2024 09:07
— with
GitHub Actions
Failure
sonika-shah
previously approved these changes
Sep 18, 2024
mohityadav766
had a problem deploying
to
test
September 18, 2024 09:24
— with
GitHub Actions
Failure
mohityadav766
had a problem deploying
to
test
September 18, 2024 09:24
— with
GitHub Actions
Failure
ayush-shah
previously approved these changes
Sep 18, 2024
mohityadav766
had a problem deploying
to
test
September 18, 2024 19:09
— with
GitHub Actions
Failure
harshach
previously approved these changes
Sep 19, 2024
chirag-madlani
had a problem deploying
to
test
September 19, 2024 06:38
— with
GitHub Actions
Failure
chirag-madlani
had a problem deploying
to
test
September 19, 2024 06:38
— with
GitHub Actions
Failure
chirag-madlani
had a problem deploying
to
test
September 19, 2024 06:38
— with
GitHub Actions
Failure
chirag-madlani
had a problem deploying
to
test
September 19, 2024 11:29
— with
GitHub Actions
Failure
chirag-madlani
had a problem deploying
to
test
September 19, 2024 11:29
— with
GitHub Actions
Failure
chirag-madlani
had a problem deploying
to
test
September 19, 2024 11:29
— with
GitHub Actions
Failure
chirag-madlani
had a problem deploying
to
test
September 19, 2024 11:29
— with
GitHub Actions
Failure
chirag-madlani
previously approved these changes
Sep 19, 2024
mohityadav766
dismissed stale reviews from chirag-madlani and harshach
via
September 20, 2024 06:10
a5a4691
mohityadav766
had a problem deploying
to
test
September 20, 2024 06:10
— with
GitHub Actions
Failure
mohityadav766
added a commit
that referenced
this pull request
Sep 20, 2024
* fix owners patch issue * rename func * typo * Add Test Case * Fix Tests --------- Co-authored-by: Sriharsha Chintalapani <harshach@users.noreply.github.com> Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com> (cherry picked from commit f4ce0e8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes Owner Patch Issue :-
The issue above is we have the populated details in refs , but we again copy the ref from owners , which can run into issue , since it can only have id and type .
For example owner.sort will itself run into issues , if the id and type are only supplied and we are trying to sort on name
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>