Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 17903: fix(data-quality): snowflake data diff #17907

Merged
merged 4 commits into from
Sep 19, 2024
Merged

Conversation

sushi30
Copy link
Contributor

@sushi30 sushi30 commented Sep 18, 2024

  • fixed schema in snowflake URL for data diff
  • added e2e for snowflake data quality

Describe your changes:

Fixes #17903

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

- fixed schema in snowflake URL for data diff
- added e2e for snowflake data quality
Copy link

@pmbrull pmbrull merged commit 21af02d into main Sep 19, 2024
7 of 15 checks passed
@pmbrull pmbrull deleted the fix-snowflake-data-diff branch September 19, 2024 15:55
sushi30 added a commit that referenced this pull request Sep 20, 2024
* fix(data-quality): snowflake data diff

- fixed schema in snowflake URL for data diff
- added e2e for snowflake data quality

* reverted unintended change

(cherry picked from commit 21af02d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data diff does not support snowflake service
2 participants