Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GEN-1578: SAML redirect leads to 404 page on UI #17978

Merged
merged 7 commits into from
Sep 27, 2024
Merged

GEN-1578: SAML redirect leads to 404 page on UI #17978

merged 7 commits into from
Sep 27, 2024
+11 −5

Conversation

karanh37
Copy link
Contributor

@karanh37 karanh37 commented Sep 24, 2024 •
edited
Loading

Describe your changes:

Fixes

Tests:
Snowflake creds expired causing failure on pw.

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@notion-workspace Notion Workspace
Copy link

SAML redirect leads to 404 page on UI

@github-actions github-actions bot added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Sep 24, 2024
@karanh37 karanh37 marked this pull request as draft September 24, 2024 13:32
@karanh37 karanh37 marked this pull request as ready for review September 24, 2024 13:41
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 24, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.42% (37451/58133) 41.14% (14890/36193) 43.22% (4523/10465)

@karanh37 karanh37 marked this pull request as draft September 25, 2024 05:42
@karanh37 karanh37 marked this pull request as ready for review September 27, 2024 11:29
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 27, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@karanh37 karanh37 merged commit c709ec6 into main Sep 27, 2024
14 of 16 checks passed
@karanh37 karanh37 deleted the saml-auth-callback branch September 27, 2024 15:10
karanh37 added a commit that referenced this pull request Sep 30, 2024
@karanh37
GEN-1578: SAML redirect leads to 404 page on UI (#17978)
4f4cf29 
* move routes to callback router

* move callback routes to global router

* added comments

* make saml and confidential callback route public

(cherry picked from commit c709ec6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@ShaileshParmar11 ShaileshParmar11 Awaiting requested review from ShaileshParmar11 ShaileshParmar11 is a code owner

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya Sachin-chaurasiya is a code owner

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karanh37 @chirag-madlani