GEN-1234 - Clean up suggestions when a user is deleted #17988
Merged
+245
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Ingestion
safe to test
pmbrull
commented
Sep 25, 2024
| @@ -213,7 +214,8 @@ | |||
| User.__name__: "/users", | |||
| CreateUserRequest.__name__: "/users", | |||
| AuthenticationMechanism.__name__: "/users/auth-mechanism", | |||
| Bot.__name__: "/bots", # We won't allow bot creation from the client | |||
| Bot.__name__: "/bots", | |||
| CreateBot.__name__: "/bots", | |||
There was a problem hiding this comment.
useful for testing
pmbrull
commented
Sep 25, 2024
| @@ -415,6 +418,9 @@ public ResultList<Suggestion> listAfter(SuggestionFilter filter, int limit, Stri | |||
| List<Suggestion> suggestions = getSuggestionList(jsons); | |||
| String beforeCursor; | |||
| String afterCursor = null; | |||
| if (nullOrEmpty(suggestions)) { | |||
| return new ResultList<>(suggestions, null, null, total); | |||
| } | |||
| beforeCursor = after == null ? null : suggestions.get(0).getUpdatedAt().toString(); | |||
There was a problem hiding this comment.
without the check we got index out of bounds
pmbrull
commented
Sep 25, 2024
| @@ -53,5 +53,5 @@ | |||
| } | |||
| }, | |||
| "additionalProperties": false, | |||
| "required": ["JWTToken", "JWTTokenExpiry"] | |||
| "required": ["JWTTokenExpiry"] | |||
There was a problem hiding this comment.
the JWTToken is created in the backend, no need to pass it when creating a user
|
The Java checkstyle failed. Please run You can install the pre-commit hooks with |
sushi30
previously approved these changes
Sep 25, 2024
|
sushi30
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>