Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR - Improve Data Quality Results List from Search #18014

Merged

Conversation

TeddyCr
Copy link
Contributor

@TeddyCr TeddyCr commented Sep 26, 2024

Describe your changes:

  • Clean aggregation parsing
  • Clean duplicated code in EntityTimeSeriesRepository
  • Added dimension and type filters for data quality test case results listing

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Improvement

  • I have added tests around the new logic.
  • For connector/ingestion changes: I updated the documentation.

@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Sep 26, 2024
Copy link

sonarcloud bot commented Sep 26, 2024

@TeddyCr TeddyCr merged commit e3f1d52 into open-metadata:main Sep 26, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data quality Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants