Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Fix missing cast to str #18016

Merged
merged 2 commits into from
Sep 27, 2024
Merged

MINOR: Fix missing cast to str #18016

merged 2 commits into from
Sep 27, 2024

Conversation

IceS2
Copy link
Contributor

@IceS2 IceS2 commented Sep 26, 2024

After migratint to Pydantic V2, we need to explicitely cast URLs to string.
This one was missing.

Type of change:

  • Bug fix

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link

sonarcloud bot commented Sep 27, 2024

@IceS2 IceS2 merged commit c9d37f6 into main Sep 27, 2024
14 of 16 checks passed
@IceS2 IceS2 deleted the fix-iceberg-rest-catalog-config branch September 27, 2024 14:03
ulixius9 pushed a commit that referenced this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants