[ER Diagrams] Add ER diagram APIs and sample data #18021
Conversation
github-actions
bot
added
Ingestion
safe to test
|
The Java checkstyle failed. Please run You can install the pre-commit hooks with |
|
The Python checkstyle failed. Please run You can install the pre-commit hooks with |
Jest test CoverageUI tests summary
|
| if (depth <= 0) { | ||
| return; | ||
| } | ||
| es.org.elasticsearch.action.search.SearchRequest searchRequest = |
There was a problem hiding this comment.
we need to put full package names here
There was a problem hiding this comment.
The file is references a specific class for the SearchRequest. hence the full name here. It is done for other APIs as well
| String direction, | ||
| boolean deleted) | ||
| throws IOException { | ||
| if (depth <= 0) { |
There was a problem hiding this comment.
how can be depth be below 0 here? we should throw an error not return
There was a problem hiding this comment.
This is a function that will be called recursively. The depth is there for handling that
E.g by default depth with start at 3 and then with each recursion it'll get decremented unless it reaches 0
openmetadata-service/src/main/java/org/openmetadata/service/search/indexes/SearchIndex.java
Outdated
Show resolved
Hide resolved
| if (depth <= 0) { | ||
| return; | ||
| } | ||
| os.org.opensearch.action.search.SearchRequest searchRequest = |
There was a problem hiding this comment.
avoid full package names like this here
1 similar comment
| @@ -644,6 +645,41 @@ public DatabaseSchema deleteDataProfilerConfig( | |||
| return addHref(uriInfo, databaseSchema); | |||
| } | |||
|
|
|||
| @GET | |||
| @Path("/getEntityRelationship") | |||
There was a problem hiding this comment.
lets not add "Get" , lets just call it as /entityRelationship. GET is indicated by the HTTP Method
There was a problem hiding this comment.
@OnkarVO7 any reason not to add this at database level?
There was a problem hiding this comment.
@harshach Main to add this at schema level was to make sure the performance remains consistent. We can extend database level too once this is out
|
@OnkarVO7 lets make sure we are adding EDIT_ENTITY_RELATIONSHIP similar to EDIT_LINEAGE. |
…tch and use only in service tables
|
|
* Add ER diag APIs and sample data * fix pylint * formatting fixes2 * fixed es client return * fixed os client return * supported TableDetailPage tabs as classBase for supporting collate only tabs * Added schema Apis * change the base class to .ts and move the component in the util files * beautify function arguments * Added optimizations * Ingestion changes * svg dimension change * supported class base tab in databaseSchema * supported classBase action button in schema table name column * added further keys data for constraint modal * fix sonar issue * remove old method to override edit action on column and shifted to DisplayNameModal for fields * supported table right panel component to further extends on collate side * minor fix around duplicate constraint * added support to update table constraints and column constraints in the UI * code optimization and minor fixes * review comments and multi col fix * added queryFilter option in NodeSuggestion and tableConstrainst to fetch and use only in service tables --------- Co-authored-by: Ashish Gupta <ashish@getcollate.io>
Describe your changes:
Add ER diagram APIs and sample data
UI :
Screen.Recording.2024-10-27.at.3.57.34.PM.mov
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>