Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor(ui): reset displayName to avoid being persisted #18024

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

chirag-madlani
Copy link
Collaborator

Describe your changes:

  • We are setting displayName once and not updating it on receiving prop change
  • I have added a usEffect to update it
  • Also scanned same component in case we are having simmiler issue for any other property

Fixes: User displayName being persisted across user

Issue

Screen.Recording.2024-09-27.at.2.30.47.PM.mov

Fix

Screen.Recording.2024-09-27.at.2.31.11.PM.mov

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
64.27% (37362/58131) 41.07% (14865/36191) 43.09% (4509/10464)

Copy link

sonarcloud bot commented Sep 27, 2024

@chirag-madlani chirag-madlani merged commit f9e70f8 into main Sep 28, 2024
16 checks passed
@chirag-madlani chirag-madlani deleted the fix-user-displayName branch September 28, 2024 09:14
Sachin-chaurasiya pushed a commit that referenced this pull request Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants