Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GEN-1584: powerbi col.lineage fix #18030

Merged
merged 1 commit into from
Sep 27, 2024
Merged

GEN-1584: powerbi col.lineage fix #18030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 6 additions & 20 deletions ingestion/src/metadata/ingestion/source/dashboard/powerbi/metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -544,12 +544,12 @@ def create_datamodel_report_lineage(
to_entity=report_entity, from_entity=datamodel_entity
)

# create the lineage between table and datamodel
yield from self.create_table_datamodel_lineage(
db_service_name=db_service_name,
tables=dataset.tables,
datamodel_entity=datamodel_entity,
)
for table in dataset.tables or []:
yield self._get_table_and_datamodel_lineage(
db_service_name=db_service_name,
table=table,
datamodel_entity=datamodel_entity,
)

# create the lineage between table and datamodel using the pbit files
if self.client.file_client:
Expand Down Expand Up @@ -678,20 +678,6 @@ def create_table_datamodel_lineage_from_files(
)
)

def create_table_datamodel_lineage(
self,
db_service_name: str,
tables: Optional[List[PowerBiTable]],
datamodel_entity: Optional[DashboardDataModel],
) -> Iterable[Either[CreateDashboardRequest]]:
"""Method to create lineage between table and datamodels"""
for table in tables or []:
yield self._get_table_and_datamodel_lineage(
db_service_name=db_service_name,
table=table,
datamodel_entity=datamodel_entity,
)

def yield_dashboard_lineage_details(
self,
dashboard_details: Union[PowerBIDashboard, PowerBIReport],
Expand Down
1 change: 1 addition & 0 deletions openmetadata-ui/src/main/resources/ui/src/constants/Lineage.constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ export const DATATYPES_HAVING_SUBFIELDS = [
'STRUCT',
'ARRAY',
'UNION',
'TABLE',
];

export const PIPELINE_EDGE_WIDTH = 200;
Expand Down
Loading