Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GEN-712: show column lineage function in edge drawer #18032

Merged
merged 4 commits into from
Sep 30, 2024
Merged

GEN-712: show column lineage function in edge drawer #18032

merged 4 commits into from
Sep 30, 2024

Conversation

karanh37
Copy link
Contributor

Describe your changes:

Fixes #16092

I worked on ... because ...

Screen.Recording.2024-09-27.at.7.39.41.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Sep 27, 2024
@karanh37 karanh37 changed the title show column lineage function in edge drawer GEN-712: show column lineage function in edge drawer Sep 27, 2024
@notion-workspace Notion Workspace
Copy link

Edge Information Function- not showing in UI

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 27, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.39% (37491/58226) 41.08% (14922/36328) 43.17% (4527/10487)

chirag-madlani
chirag-madlani reviewed Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@chirag-madlani chirag-madlani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have playwright test around the same?

@karanh37
Copy link
Contributor Author

Can we have playwright test around the same?

There is no UI way to add a function. Can be added from ingestion or API way.
For doing the API way will require ID's of each column which is not available to extract.

@karanh37
Copy link
Contributor Author

Added function info, using API for e2e

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 30, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@karanh37 karanh37 merged commit 47cde16 into main Sep 30, 2024
15 of 16 checks passed
@karanh37 karanh37 deleted the lineage-function branch September 30, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@ShaileshParmar11 ShaileshParmar11 Awaiting requested review from ShaileshParmar11 ShaileshParmar11 is a code owner

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya Sachin-chaurasiya is a code owner

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edge Information Function- not showing in UI
2 participants
@karanh37 @chirag-madlani