Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #18005: Mask Greenplum Password #18047

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Fix #18005: Mask Greenplum Password #18047

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a5434a
Fix #18005: Mark Greenplum Password
ulixius9 Sep 30, 2024
1c27c8b
fix method
ulixius9 Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...in/java/org/openmetadata/service/secrets/converter/GreenplumConnectionClassConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
import java.util.List;
import org.openmetadata.schema.security.ssl.ValidateSSLClientConfig;
import org.openmetadata.schema.services.connections.database.GreenplumConnection;
import org.openmetadata.schema.services.connections.database.common.IamAuthConfig;
import org.openmetadata.schema.services.connections.database.common.basicAuth;
import org.openmetadata.service.util.JsonUtils;

/**
Expand All @@ -24,6 +26,8 @@
public class GreenplumConnectionClassConverter extends ClassConverter {

private static final List<Class<?>> SSL_SOURCE_CLASS = List.of(ValidateSSLClientConfig.class);
private static final List<Class<?>> CONFIG_SOURCE_CLASSES =
List.of(basicAuth.class, IamAuthConfig.class);

public GreenplumConnectionClassConverter() {
super(GreenplumConnection.class);
Expand All @@ -34,6 +38,9 @@ public Object convert(Object object) {
GreenplumConnection greenplumConnection =
(GreenplumConnection) JsonUtils.convertValue(object, this.clazz);

tryToConvert(greenplumConnection.getAuthType(), CONFIG_SOURCE_CLASSES)
.ifPresent(greenplumConnection::setSslConfig);

tryToConvert(greenplumConnection.getSslConfig(), SSL_SOURCE_CLASS)
.ifPresent(greenplumConnection::setSslConfig);

Expand Down
Loading