Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor(ui): fix role page size from 10 to 50 #18049

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

chirag-madlani
Copy link
Collaborator

@chirag-madlani chirag-madlani commented Sep 30, 2024

Describe your changes:

Fixes:

  • Roles is not being listed if more than 10 on Bots page
  • Bot name being overflowed, Added ellipsis + tooltip to fix it

Tested:

  • User page Roles selection working with 50 page size already
  • Replicated same on Bots Page
  • Need to have ES search here to avoid heavy page size with infinite scrolling like User selection as future scope
Screen.Recording.2024-09-30.at.3.15.01.PM.mov

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
64.41% (37520/58256) 41.09% (14912/36294) 43.17% (4526/10485)

Copy link

sonarcloud bot commented Sep 30, 2024

@chirag-madlani chirag-madlani merged commit 85519cf into main Sep 30, 2024
14 of 16 checks passed
@chirag-madlani chirag-madlani deleted the fix-bot-role branch September 30, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants