Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(test): ingestion playwright flakiness #18051

Merged
merged 3 commits into from
Oct 1, 2024
Merged

chore(test): ingestion playwright flakiness #18051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac19991
chore(test): ingestion playwright flakiness
chirag-madlani Sep 30, 2024
458aeb8
Merge branch 'main' into fix-ingestion-aut
chirag-madlani Sep 30, 2024
aa5f199
Merge branch 'main' into fix-ingestion-aut
chirag-madlani Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions ...adata-ui/src/main/resources/ui/playwright/support/entity/ingestion/MySqlIngestionClass.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,14 +125,8 @@ class MysqlIngestionClass extends ServiceBaseClass {
)
.then((res) => res.json());

// Re-deploy before running the ingestion
await page.click(
`[data-row-key*="${response.data[0].name}"] [data-testid="more-actions"]`
);
await page.getByTestId('re-deploy-button').click();

// need manual wait to settle down the deployed pipeline, before triggering the pipeline
await page.waitForTimeout(2000);
await page.waitForTimeout(3000);

await page.click(
`[data-row-key*="${response.data[0].name}"] [data-testid="more-actions"]`
Expand All @@ -141,6 +135,9 @@ class MysqlIngestionClass extends ServiceBaseClass {

await toastNotification(page, `Pipeline triggered successfully!`);

// need manual wait to make sure we are awaiting on latest run results
await page.waitForTimeout(2000);

await this.handleIngestionRetry('profiler', page);
});

Expand Down
11 changes: 4 additions & 7 deletions ...ta-ui/src/main/resources/ui/playwright/support/entity/ingestion/PostgresIngestionClass.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,14 +131,8 @@ class PostgresIngestionClass extends ServiceBaseClass {
)
.then((res) => res.json());

// Re-deploy before running the ingestion
await page.click(
`[data-row-key*="${response.data[0].name}"] [data-testid="more-actions"]`
);
await page.getByTestId('re-deploy-button').click();

// need manual wait to settle down the deployed pipeline, before triggering the pipeline
await page.waitForTimeout(2000);
await page.waitForTimeout(3000);
await page.click(
`[data-row-key*="${response.data[0].name}"] [data-testid="more-actions"]`
);
Expand All @@ -147,6 +141,9 @@ class PostgresIngestionClass extends ServiceBaseClass {

await toastNotification(page, `Pipeline triggered successfully!`);

// need manual wait to make sure we are awaiting on latest run results
await page.waitForTimeout(2000);

await this.handleIngestionRetry('usage', page);
});

Expand Down
11 changes: 4 additions & 7 deletions ...rc/main/resources/ui/playwright/support/entity/ingestion/RedshiftWithDBTIngestionClass.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,21 +153,18 @@ class RedshiftWithDBTIngestionClass extends ServiceBaseClass {
)
.then((res) => res.json());

// Re-deploy before running the ingestion
await page.click(
`[data-row-key*="${response.data[0].name}"] [data-testid="more-actions"]`
);
await page.getByTestId('re-deploy-button').click();

// need manual wait to settle down the deployed pipeline, before triggering the pipeline
await page.waitForTimeout(2000);
await page.waitForTimeout(3000);
await page.click(
`[data-row-key*="${response.data[0].name}"] [data-testid="more-actions"]`
);
await page.getByTestId('run-button').click();

await toastNotification(page, `Pipeline triggered successfully!`);

// need manual wait to make sure we are awaiting on latest run results
await page.waitForTimeout(2000);

await this.handleIngestionRetry('dbt', page);
});

Expand Down
18 changes: 8 additions & 10 deletions ...metadata-ui/src/main/resources/ui/playwright/support/entity/ingestion/ServiceBaseClass.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,18 +177,17 @@ class ServiceBaseClass {
.getByTestId('loader')
.waitFor({ state: 'detached' });

// Re-deploy before running the ingestion
await page.getByTestId('more-actions').first().click();
await page.getByTestId('re-deploy-button').click();

// need manual wait to settle down the deployed pipeline, before triggering the pipeline
await page.waitForTimeout(2000);
await page.waitForTimeout(3000);

await page.getByTestId('more-actions').first().click();
await page.getByTestId('run-button').click();

await toastNotification(page, `Pipeline triggered successfully!`);

// need manual wait to make sure we are awaiting on latest run results
await page.waitForTimeout(2000);

await this.handleIngestionRetry('metadata', page);
}

Expand Down Expand Up @@ -444,18 +443,17 @@ class ServiceBaseClass {
.getByRole('cell', { name: 'Pause Logs' })
.waitFor({ state: 'visible' });

// Re-deploy before running the ingestion
await page.getByTestId('more-actions').first().click();
await page.getByTestId('re-deploy-button').click();

// need manual wait to settle down the deployed pipeline, before triggering the pipeline
await page.waitForTimeout(2000);
await page.waitForTimeout(3000);

await page.getByTestId('more-actions').first().click();
await page.getByTestId('run-button').click();

await toastNotification(page, `Pipeline triggered successfully!`);

// need manual wait to make sure we are awaiting on latest run results
await page.waitForTimeout(2000);

// Wait for success
await this.handleIngestionRetry('metadata', page);

Expand Down
Loading