Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #18035 - getting type null exception on feed #18052

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Fix #18035 - getting type null exception on feed #18052

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d32482
Fix #18035 - getting type null exception on feed
sonika-shah Sep 30, 2024
250b009
Merge branch 'main' into issue-18035-v2
sonika-shah Sep 30, 2024
91af7ab
Merge branch 'main' into issue-18035-v2
sonika-shah Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/CollectionDAO.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1363,7 +1363,7 @@ int listCountThreadsByEntityLink(
+ " SELECT te.entityLink, te.type, te.taskStatus, te.id "
+ " FROM thread_entity te "
+ " WHERE te.entityId = :entityId "
+ ") AS combined "
+ ") AS combined WHERE combined.type IS NOT NULL "
+ "GROUP BY type, taskStatus, entityLink")
@RegisterRowMapper(ThreadCountFieldMapper.class)
List<List<String>> listCountByEntityLink(
Expand Down Expand Up @@ -1639,7 +1639,7 @@ default List<List<String>> listCountThreadsByGlossaryAndTerms(
+ " AND (:toType2 IS NULL OR fr.toType LIKE CONCAT(:toType2, '.%') OR fr.toType = :toType2) "
+ " AND fr.relation = 3 "
+ " ) "
+ ") AS combined_results "
+ ") AS combined_results WHERE combined_results.type is not NULL "
+ "GROUP BY entityLink, type, taskStatus ")
@RegisterRowMapper(ThreadCountFieldMapper.class)
List<List<String>> listCountThreadsByGlossaryAndTerms(
Expand Down
Loading