Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVEMENT] Add Support for Custom Headers and HTTP Methods in Generic Webhook #18056

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[IMPROVEMENT] Add Support for Custom Headers and HTTP Methods in Generic Webhook #18056

wants to merge 5 commits into from
+138 −98

Conversation

Siddhanttimeline
Copy link
Contributor

@Siddhanttimeline Siddhanttimeline commented Sep 30, 2024 •
edited
Loading

Describe your changes:

Fixes #17879

  • Support for custom headers and http methods (POST/PUT) in generic webhook.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Siddhanttimeline Siddhanttimeline added backend safe to test Add this label to run secure Github workflows on PRs labels Sep 30, 2024
@Siddhanttimeline Siddhanttimeline self-assigned this Sep 30, 2024
@Siddhanttimeline Siddhanttimeline requested a review from a team as a code owner September 30, 2024 20:05
@Siddhanttimeline Siddhanttimeline changed the title [IMPROV] Add support for custom headers and JSON payload configuration in webhook [IMPROVEMENT] Add Support for Custom Headers, JSON Payload, and HTTP Methods in Generic Webhook Oct 1, 2024
@Siddhanttimeline Siddhanttimeline changed the title [IMPROVEMENT] Add Support for Custom Headers, JSON Payload, and HTTP Methods in Generic Webhook [IMPROVEMENT] Add Support for Custom Headers and HTTP Methods in Generic Webhook Oct 1, 2024
@Siddhanttimeline
Copy link
Contributor Author

@aniketkatkar97 We will require changes in the UI side for this.

  1. Field for providing custom headers for webhook.
  2. Field for choosing between POST and PUT http method for webhook.

@Siddhanttimeline Siddhanttimeline mentioned this pull request Oct 1, 2024
Open
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 1, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohityadav766 mohityadav766 mohityadav766 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@Siddhanttimeline Siddhanttimeline

Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Webhooks in Alerts: add host (POST method), head, JSON.
2 participants
@Siddhanttimeline @mohityadav766