Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes GEN-1260: Add Validators while creating table to escape special characters #18456

Merged
merged 19 commits into from
Nov 18, 2024

Conversation

ayush-shah
Copy link
Member

@ayush-shah ayush-shah commented Oct 29, 2024

Describe your changes:

Fixes GEN-1260
This allows support for entities that have :: or >
It is an incremental change that is shipped for Table, Columns ( for metadata, profiling and data quality )
Additionally it now supports names with quotes and spaces

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Copy link

sonarcloud bot commented Nov 18, 2024

@ayush-shah ayush-shah merged commit 6f1df37 into main Nov 18, 2024
24 of 25 checks passed
@ayush-shah ayush-shah deleted the issue-entity-link branch November 18, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants