Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GEN 1683 - Add Column Value to be At Expected Location Test #18524

Merged
merged 8 commits into from
Nov 6, 2024
Merged

GEN 1683 - Add Column Value to be At Expected Location Test #18524

merged 8 commits into from
Nov 6, 2024

Conversation

TeddyCr
Copy link
Contributor

@TeddyCr TeddyCr commented Nov 5, 2024 •
edited
Loading

Describe your changes:

  • Add Column Value to be At Expected Location Test

NB: iterows() for the pandas implementation it not the optimal approach

image

image

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

New feature

  • The issue properly describes why the new feature is needed, what's the goal, and how we are building it. Any discussion
    or decision-making process is reflected in the issue.
  • I have updated the documentation.
  • I have added tests around the new logic.

@TeddyCr TeddyCr requested review from a team as code owners November 5, 2024 16:19
@notion-workspace Notion Workspace
Copy link

Geo Lat/Long test case implementation

@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Nov 5, 2024
pmbrull
pmbrull previously approved these changes Nov 5, 2024
View reviewed changes
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 5, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@TeddyCr TeddyCr merged commit d579008 into open-metadata:main Nov 6, 2024
24 of 26 checks passed
TeddyCr added a commit that referenced this pull request Nov 6, 2024
@TeddyCr
GEN 1683 - Add Column Value to be At Expected Location Test (#18524)
1f2e30f 
* feat: added column value to be in expected location test

* fix: renamed value -> values

* doc: added 1.6 documentatio entry

* style: ran python linting

* fix: move data packaging to pyproject.yaml

* fix: add init file back for data package

* fix: failing test case

(cherry picked from commit d579008)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmbrull pmbrull pmbrull approved these changes

Assignees
No one assigned
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TeddyCr @pmbrull