Search Index Optimizations #18649
Merged
Search Index Optimizations #18649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
backend
safe to test
|
harshach
approved these changes
Nov 18, 2024
TeddyCr
reviewed
Nov 18, 2024
Comment on lines
+133
to
+142
| for (int i = 0; i < response.getItems().length; i++) { | ||
| BulkItemResponse itemResponse = response.getItems()[i]; | ||
| if (itemResponse.isFailed()) { | ||
| String failureMessage = itemResponse.getFailureMessage(); | ||
| String entityData = requests.get(i).toString(); | ||
| entityErrorList.add( | ||
| new EntityError().withMessage(failureMessage).withEntity(entityData)); | ||
| LOG.warn("Bulk item failed: {}", failureMessage); | ||
| } | ||
| } |
There was a problem hiding this comment.
What do you think of using a Stream here like this (caveat i have not tested it)
entityErrorList = response.getItems().length > 0 ? response.getItems()
.stream()
.filter(BulkItemResponse::isFailed)
.map(
item -> {
int idx = Arrays.asList(response.getItems()).indexOf(item);
String failureMessage = itemResponse.getFailureMessage()
EntityError().withMessage(itemResponse.getFailureMessage()).withEntity(request.get(idx).toString)
LOG.warn("Bulk item failed: {}", failureMessage);
}).toList() : entityErrorList;Also do you know if List<EntityError> entityErrorList will be mutable and how it will behave with the multithreading?
TeddyCr
reviewed
Nov 18, 2024
Comment on lines
+146
to
+150
| for (BulkItemResponse item : response.getItems()) { | ||
| if (item.isFailed()) { | ||
| failed++; | ||
| } | ||
| } |
There was a problem hiding this comment.
can we do something like
int failed = entityErrorList.size()I believe this prevents us from looping twice over the response
TeddyCr
reviewed
Nov 18, 2024
Comment on lines
+234
to
+243
| for (int i = 0; i < response.getItems().length; i++) { | ||
| BulkItemResponse itemResponse = response.getItems()[i]; | ||
| if (itemResponse.isFailed()) { | ||
| String failureMessage = itemResponse.getFailureMessage(); | ||
| String entityData = bulkRequest.requests().get(i).toString(); | ||
| entityErrorList.add( | ||
| new EntityError().withMessage(failureMessage).withEntity(entityData)); | ||
| LOG.warn("Bulk item failed on retry {}: {}", attempt, failureMessage); | ||
| } | ||
| } |
There was a problem hiding this comment.
Same question here https://github.com/open-metadata/OpenMetadata/pull/18649/files#r1846975047
TeddyCr
reviewed
Nov 18, 2024
Comment on lines
+247
to
+251
| for (BulkItemResponse item : response.getItems()) { | ||
| if (item.isFailed()) { | ||
| failed++; | ||
| } | ||
| } |
There was a problem hiding this comment.
same question here https://github.com/open-metadata/OpenMetadata/pull/18649/files#r1846981743
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>