Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: edit display name #18720

Merged
merged 11 commits into from
Nov 28, 2024
Merged

Feat: edit display name #18720

merged 11 commits into from
Nov 28, 2024

Conversation

pranita09
Copy link
Contributor

@pranita09 pranita09 commented Nov 21, 2024 •
edited
Loading

Describe your changes:

Edit Display Name functionality for the following pages.

  • Database Service - DatabaseSchema - Table
  • Dashboard Service
  • Pipeline Service
  • Messaging Service
  • ML Model Service
  • Container/Storage Service
  • Search Service
  • API Service
Screen.Recording.2024-11-27.at.12.47.07.PM.mov
Screen.Recording.2024-11-27.at.11.35.43.AM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@pranita09 pranita09 marked this pull request as ready for review November 21, 2024 10:03
@Ashish8689 Ashish8689 added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Nov 21, 2024
Ashish8689
Ashish8689 reviewed Nov 21, 2024
View reviewed changes
...ources/ui/src/components/Database/DatabaseSchema/DatabaseSchemaTable/DatabaseSchemaTable.tsx Outdated Show resolved Hide resolved
...ources/ui/src/components/Database/DatabaseSchema/DatabaseSchemaTable/DatabaseSchemaTable.tsx Outdated Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/src/pages/DatabaseSchemaPage/SchemaTablesTab.tsx Outdated Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/src/pages/DatabaseSchemaPage/SchemaTablesTab.tsx Outdated Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/src/pages/ServiceDetailsPage/ServiceMainTabContent.tsx Outdated Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/src/pages/ServiceDetailsPage/ServiceMainTabContent.tsx Outdated Show resolved Hide resolved
aniketkatkar97
aniketkatkar97 reviewed Nov 21, 2024
View reviewed changes
...ources/ui/src/components/Database/DatabaseSchema/DatabaseSchemaTable/DatabaseSchemaTable.tsx Outdated Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/src/components/common/DisplayName/DisplayName.test.tsx Outdated Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/src/components/common/DisplayName/DisplayName.test.tsx Outdated Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/src/components/common/DisplayName/DisplayName.tsx Outdated Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/src/components/common/DisplayName/DisplayName.tsx Outdated Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/src/components/common/DisplayName/DisplayName.tsx Outdated Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/src/components/common/DisplayName/DisplayName.tsx Outdated Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/src/pages/DatabaseSchemaPage/SchemaTablesTab.tsx Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/src/pages/ServiceDetailsPage/ServiceMainTabContent.tsx Outdated Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/src/pages/ServiceDetailsPage/ServiceMainTabContent.tsx Show resolved Hide resolved
ShaileshParmar11
ShaileshParmar11 reviewed Nov 27, 2024
View reviewed changes
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left few comment

openmetadata-ui/src/main/resources/ui/src/components/common/DisplayName/DisplayName.tsx Outdated Show resolved Hide resolved
...adata-ui/src/main/resources/ui/src/pages/ServiceVersionPage/ServiceVersionMainTabContent.tsx Outdated Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/webpack.config.dev.js Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
4.7% Duplication on New Code

See analysis details on SonarQube Cloud

@ShaileshParmar11 ShaileshParmar11 merged commit 9d37ff0 into open-metadata:main Nov 28, 2024
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashish8689 Ashish8689 Ashish8689 left review comments

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@aniketkatkar97 aniketkatkar97 aniketkatkar97 left review comments

@karanh37 karanh37 Awaiting requested review from karanh37

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pranita09 @aniketkatkar97 @Ashish8689 @ShaileshParmar11