playwright: added initial db setup for playwright test #18832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaileshParmar11
requested review from
karanh37,
chirag-madlani and
Sachin-chaurasiya
as code owners
ShaileshParmar11
had a problem deploying
to
test
GitHub Actions
Failure
ShaileshParmar11
had a problem deploying
to
test
GitHub Actions
Failure
ShaileshParmar11
had a problem deploying
to
test
GitHub Actions
Failure
ShaileshParmar11
had a problem deploying
to
test
GitHub Actions
Failure
github-actions
bot
added
safe to test
Jest test CoverageUI tests summary
|
ShaileshParmar11
had a problem deploying
to
test
GitHub Actions
Error
ShaileshParmar11
had a problem deploying
to
test
GitHub Actions
Error
ShaileshParmar11
had a problem deploying
to
test
GitHub Actions
Error
ShaileshParmar11
had a problem deploying
to
test
GitHub Actions
Error
ShaileshParmar11
changed the title
ShaileshParmar11
had a problem deploying
to
test
GitHub Actions
Failure
ShaileshParmar11
temporarily deployed
to
test
GitHub Actions
Inactive
ShaileshParmar11
had a problem deploying
to
test
GitHub Actions
Failure
ShaileshParmar11
had a problem deploying
to
test
GitHub Actions
Failure
| @@ -170,7 +170,7 @@ class ServiceBaseClass { | |||
|
|
|||
| // Header available once page loads | |||
| await page.waitForSelector('[data-testid="data-assets-header"]'); | |||
| await page.getByTestId('loader').waitFor({ state: 'detached' }); | |||
| await page.getByTestId('loader').first().waitFor({ state: 'detached' }); | |||
There was a problem hiding this comment.
I think following would be a better option here instead of first() to make sure we are waiting for the exact loader
await page
.getByTestId('table-container')
.getByTestId('loader')
.waitFor({ state: 'detached' });
|
karanh37
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
added initial setup
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>