Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supported editUser permission in user tab for team page #18987

Merged
merged 8 commits into from
Dec 13, 2024

Conversation

Ashish8689
Copy link
Contributor

@Ashish8689 Ashish8689 commented Dec 10, 2024

Describe your changes:

Fixes

  • I worked on supporting editUser permission in user tab for team page.
  • Add and Remove user can be done with this permission set.
  • Added Playwright test for the same.
  • Backed support is also added for this permission on the put and delete api
Screen.Recording.2024-12-11.at.3.40.08.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

github-actions bot commented Dec 10, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
63.88% (40069/62726) 40.39% (16044/39721) 43.07% (4805/11157)

harshach
harshach previously approved these changes Dec 11, 2024
chirag-madlani
chirag-madlani previously approved these changes Dec 12, 2024
Copy link

Copy link

@mohityadav766 mohityadav766 merged commit 9e6078f into main Dec 13, 2024
21 of 27 checks passed
@mohityadav766 mohityadav766 deleted the edit-user-permission-team branch December 13, 2024 18:11
Ashish8689 added a commit that referenced this pull request Dec 19, 2024
* supported editUser permission in user tab for team page

* remove edit all permission check in teams add/remove user api

* added playwright test for the editUser permission

* Added playwright test for data consumer user and remove no used field from the advance api call

---------

Co-authored-by: sonikashah <sonikashah94@gmail.com>
Co-authored-by: sonika-shah <58761340+sonika-shah@users.noreply.github.com>
(cherry picked from commit 9e6078f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants