Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: fix(error-apps): reset apps in error state #19052

Merged
merged 4 commits into from
Dec 19, 2024
Merged

Conversation

sushi30
Copy link
Contributor

@sushi30 sushi30 commented Dec 13, 2024

Describe your changes:

It is not trivial to reproduce this as it is unclear from quartz documentation how the error state is achieved. This changes resets any triggers in error state on quartz on app start. This is not related to the app logic failing but rather to quartz failing to manage the app execution. There is not much documentation about the ERROR state in quartz. I used this SO post as reference.

Screen.Recording.2024-12-13.at.17.55.58.mov

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link

@mohityadav766 mohityadav766 merged commit 6fab88a into main Dec 19, 2024
14 of 19 checks passed
@mohityadav766 mohityadav766 deleted the app-re-initialize branch December 19, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants