-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: fix(error-apps): reset apps in error state #19052
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Ingestion
safe to test
Add this label to run secure Github workflows on PRs
labels
Dec 13, 2024
mohityadav766
approved these changes
Dec 16, 2024
Quality Gate passed for 'open-metadata-ingestion'Issues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
It is not trivial to reproduce this as it is unclear from quartz documentation how the error state is achieved. This changes resets any triggers in error state on quartz on app start. This is not related to the app logic failing but rather to quartz failing to manage the app execution. There is not much documentation about the
ERROR
state in quartz. I used this SO post as reference.Screen.Recording.2024-12-13.at.17.55.58.mov
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>