Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Permissions on TestSuite and TestCases #19072

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+14 −4
Open

User Permissions on TestSuite and TestCases #19072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
41d7168
issue-11002: user with Delete permission not able to delete testCases
harshach Dec 14, 2024
85c9eb1
Fix creation of testSuite if there are conditions in policies
harshach Dec 14, 2024
415d463
Merge branch 'main' into issue-11002-v1
harshach Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/TestSuiteRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,14 @@ public void setFullyQualifiedName(TestSuite testSuite) {
}
}

@Override
public EntityInterface getParentEntity(TestSuite entity, String fields) {
if (entity.getExecutable()) {
return Entity.getEntity(entity.getExecutableEntityReference(), fields, ALL);
}
return null;
}

private TestSummary getTestCasesExecutionSummary(JsonObject aggregation) {
// Initialize the test summary with 0 values
TestSummary testSummary =
Expand Down
4 changes: 2 additions & 2 deletions ...ta-service/src/main/java/org/openmetadata/service/resources/dqtests/TestCaseResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -830,7 +830,7 @@ public Response delete(
String fqn) {
ResourceContextInterface resourceContext = TestCaseResourceContext.builder().name(fqn).build();
OperationContext operationContext =
new OperationContext(Entity.TABLE, MetadataOperation.EDIT_TESTS);
new OperationContext(Entity.TEST_CASE, MetadataOperation.DELETE);
authorizer.authorize(securityContext, operationContext, resourceContext);
return deleteByName(uriInfo, securityContext, fqn, recursive, hardDelete);
}
Expand All @@ -854,7 +854,7 @@ public Response deleteLogicalTestCase(
@PathParam("id") UUID id) {
ResourceContextInterface resourceContext = TestCaseResourceContext.builder().id(id).build();
OperationContext operationContext =
new OperationContext(Entity.TEST_SUITE, MetadataOperation.EDIT_TESTS);
new OperationContext(Entity.TEST_CASE, MetadataOperation.DELETE);
authorizer.authorize(securityContext, operationContext, resourceContext);
DeleteResponse<TestCase> response =
repository.deleteTestCaseFromLogicalTestSuite(testSuiteId, id);
Expand Down
6 changes: 4 additions & 2 deletions ...a-service/src/main/java/org/openmetadata/service/resources/dqtests/TestSuiteResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,7 +689,8 @@ public Response delete(
@Parameter(description = "Id of the logical test suite", schema = @Schema(type = "UUID"))
@PathParam("id")
UUID id) {
OperationContext operationContext = new OperationContext(entityType, MetadataOperation.DELETE);
OperationContext operationContext =
new OperationContext(Entity.TEST_SUITE, MetadataOperation.DELETE);
authorizer.authorize(securityContext, operationContext, getResourceContextById(id));
TestSuite testSuite = Entity.getEntity(Entity.TEST_SUITE, id, "*", ALL);
if (Boolean.TRUE.equals(testSuite.getExecutable())) {
Expand Down Expand Up @@ -724,7 +725,8 @@ public Response delete(
@Parameter(description = "FQN of the logical test suite", schema = @Schema(type = "String"))
@PathParam("name")
String name) {
OperationContext operationContext = new OperationContext(entityType, MetadataOperation.DELETE);
OperationContext operationContext =
new OperationContext(Entity.TEST_SUITE, MetadataOperation.DELETE);
authorizer.authorize(securityContext, operationContext, getResourceContextByName(name));
TestSuite testSuite = Entity.getEntityByName(Entity.TEST_SUITE, name, "*", ALL);
if (Boolean.TRUE.equals(testSuite.getExecutable())) {
Expand Down
Loading