Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SQL masking issue where only one statement is processed with sqlparse #19105

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mkohei
Copy link

@mkohei mkohei commented Dec 17, 2024

#19122

Describe your changes:

Fixes that masker with sqlparse returns only first statement:
https://github.com/open-metadata/OpenMetadata/blob/1.5.11-release/ingestion/src/metadata/ingestion/lineage/masker.py#L34-L79

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@mkohei mkohei changed the title Update mask_literals_with_sqlparse function to handle multiple SQL st… Fix SQL masking issue where only one statement is processed with sqlparse Dec 17, 2024
@mkohei mkohei marked this pull request as ready for review December 17, 2024 08:16
@mkohei mkohei requested a review from a team as a code owner December 17, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant