Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code Improv] Added Mappers #19111

Merged
merged 5 commits into from
Dec 20, 2024
Merged

[Code Improv] Added Mappers #19111

merged 5 commits into from
Dec 20, 2024

Conversation

mohityadav766
Copy link
Contributor

@mohityadav766 mohityadav766 commented Dec 17, 2024

Describe your changes:

Added Mappers and moved logic from controller to mapper class for reources
Add Mappers for create Entity to Entity Schema conversion

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

github-actions bot commented Dec 17, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
63.88% (40103/62780) 40.43% (16074/39760) 43.08% (4810/11165)

sonika-shah
sonika-shah previously approved these changes Dec 17, 2024
harshach
harshach previously approved these changes Dec 18, 2024
@mohityadav766 mohityadav766 dismissed stale reviews from harshach and sonika-shah via 33a441f December 19, 2024 09:51
Copy link

@mohityadav766 mohityadav766 merged commit 9d934cb into main Dec 20, 2024
20 of 27 checks passed
@mohityadav766 mohityadav766 deleted the add-mappers branch December 20, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants