Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dbt Table not found Issue #19117

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

SumanMaharana
Copy link
Contributor

Describe your changes:

Fix dbt Table not found Issue and added more debug logs

In some cases from the get_entity_from_es_result we get

[None, None, None, Table(id=Uuid(root=UUID('c77478b8-2089-435f-a4c3-e6409a60e334')), name=EntityName(roo...ceHash='c757a17febf7af076b0bb831a1b85fb1'), Table(id=Uuid(root=UUID('85332318-d12e-4ad2-b921-b65b969881b9')), name=EntityName(roo...ceHash='8690a349a24ef5b70d9758dbf2bd0924')]

Here the actual result is at index 3 instead of index 0
We are returning index 0 without doing any none value check here

when testing found out it occurs mostly when an ingestion is run and is failed mid execution or started and killed in between. so filtering and returning the first not none value from the entity list for dbt

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link

@ulixius9 ulixius9 merged commit 6dc7e5c into open-metadata:main Dec 18, 2024
14 of 17 checks passed
SumanMaharana added a commit that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants