Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Fix Table constraint relationships for SoftDeleted entities. #19129

Merged
merged 2 commits into from
Dec 19, 2024
Merged

MINOR: Fix Table constraint relationships for SoftDeleted entities. #19129

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af92117
Update TableRepository.java
IceS2 Dec 18, 2024
7c00a94
Fix Checkstyle
IceS2 Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/TableRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1138,7 +1138,7 @@ private void validateTableConstraints(Table table) {
String toParent = FullyQualifiedName.getParentFQN(column);
String columnName = FullyQualifiedName.getColumnName(column);
try {
Table toTable = findByName(toParent, NON_DELETED);
Table toTable = findByName(toParent, ALL);
validateColumn(toTable, columnName);
} catch (EntityNotFoundException e) {
throw new EntitySpecViolationException("Table not found: " + toParent);
Expand Down Expand Up @@ -1232,8 +1232,7 @@ private void addConstraintRelationship(Table table, List<TableConstraint> constr
for (String column : constraint.getReferredColumns()) {
String toParent = FullyQualifiedName.getParentFQN(column);
try {
EntityReference toTable =
Entity.getEntityReferenceByName(TABLE, toParent, NON_DELETED);
EntityReference toTable = Entity.getEntityReferenceByName(TABLE, toParent, ALL);
addRelationship(
table.getId(), toTable.getId(), TABLE, TABLE, Relationship.RELATED_TO);
} catch (EntityNotFoundException e) {
Expand Down
Loading