Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix e2e tests #19130

Merged
merged 7 commits into from
Dec 19, 2024
Merged

Fix e2e tests #19130

merged 7 commits into from
Dec 19, 2024

Conversation

IceS2
Copy link
Contributor

@IceS2 IceS2 commented Dec 18, 2024

Fixing some E2E tests

Type of change:

  • Bug fix

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@IceS2 IceS2 requested a review from a team as a code owner December 18, 2024 11:03
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Dec 18, 2024
harshsoni2024
harshsoni2024 previously approved these changes Dec 19, 2024
View reviewed changes
@pmbrull pmbrull merged commit efbdf21 into main Dec 19, 2024
12 of 16 checks passed
@pmbrull pmbrull deleted the fix-e2e-tests branch December 19, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmbrull pmbrull pmbrull approved these changes

@harshsoni2024 harshsoni2024 harshsoni2024 left review comments

Assignees
No one assigned
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IceS2 @pmbrull @harshsoni2024