add semversion condition #188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -73,8 +73,10 @@ spec: | |||
| {{ .Values.livenessProbe | toYaml | indent 12 | trim }} | |||
| readinessProbe: | |||
| {{ .Values.readinessProbe | toYaml | indent 12 | trim }} | |||
| {{- if (semverCompare ">=1.16-0" .Capabilities.KubeVersion.GitVersion) }} | |||
There was a problem hiding this comment.
Hello @naturalett . Any particular reason for this backward compatibility ?
We currently only support upto latest 3 major kubernetes versions as for the Kubernetes Versions Compatibility Matrix here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes :
I added semverCompare condition in the deployment template because the attribute of startupProbe doesn't work for kubernetes version that is below <1.16-0
Type of change :
Frontend Preview (Screenshots) :
For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.
Checklist:
Reviewers
@shahsank3t
@harshach