Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Prepare 1.2.1 Application Release #195

Merged
merged 5 commits into from
Nov 13, 2023
Merged

feat: Prepare 1.2.1 Application Release #195

merged 5 commits into from
Nov 13, 2023

Conversation

akash-jain-10
Copy link
Collaborator

@akash-jain-10 akash-jain-10 commented Nov 10, 2023 •
edited
Loading

Describe your changes :

  • fix: remove MIGRATION_EXTENSION_PATH
  • fix: remove basic login extended configurations

Type of change :

  • Bug fix
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my own.
  • I have tagged my reviewers below.
  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

@akash-jain-10 akash-jain-10 self-assigned this Nov 10, 2023
tutte
tutte approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@tutte tutte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Remember to communicate properly the replacement of ElasticSearch by Opensearch

@akash-jain-10 akash-jain-10 merged commit eba3bf4 into main Nov 13, 2023
1 check passed
@akash-jain-10 akash-jain-10 deleted the feat/prepare-1-2-1-app-release branch November 13, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tutte tutte tutte approved these changes

@harshach harshach Awaiting requested review from harshach

@dhruvinmaniar123 dhruvinmaniar123 Awaiting requested review from dhruvinmaniar123

@mohityadav766 mohityadav766 Awaiting requested review from mohityadav766

Assignees

@akash-jain-10 akash-jain-10

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akash-jain-10 @tutte