-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update template files to use env from secrets #196
Merged
akash-jain-10
merged 11 commits into
open-metadata:main
from
preetsshah:omd-use-secret-env
Dec 8, 2023
Merged
Update template files to use env from secrets #196
akash-jain-10
merged 11 commits into
open-metadata:main
from
preetsshah:omd-use-secret-env
Dec 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with a condition
Hi @preetsshah, |
Hi @tutte, |
akash-jain-10
approved these changes
Dec 7, 2023
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes :
I worked on updating the secret for openmetadata server. Currently database configs are injected through _helpers.tpl template to the containers via env instruction in deployment. With this change, the database configs will be stored in secret and will be passed though envFrom instruction to the containers.
Type of change :
Checklist:
Reviewers
@akash-jain-10