Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update template files to use env from secrets #196

Merged
merged 11 commits into from
Dec 8, 2023

Conversation

preetsshah
Copy link
Contributor

Describe your changes :

I worked on updating the secret for openmetadata server. Currently database configs are injected through _helpers.tpl template to the containers via env instruction in deployment. With this change, the database configs will be stored in secret and will be passed though envFrom instruction to the containers.

Type of change :

  • Improvement

Checklist:

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my own.
  • I have tagged my reviewers below.
  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

@akash-jain-10

@preetsshah preetsshah marked this pull request as ready for review November 23, 2023 05:39
@tutte
Copy link
Contributor

tutte commented Dec 4, 2023

Hi @preetsshah,
Thank you for the PR, we will review it in the following days.
At first glance I love the approach and the cleanness 🙌 . I think we should provide the option to create the secrets but looks promising.

@preetsshah
Copy link
Contributor Author

Hi @tutte,
I've updated the chart as per your suggestion. Thanks!

@akash-jain-10 akash-jain-10 merged commit b19f7d5 into open-metadata:main Dec 8, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants