Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenMetadata - Change default bind address to 0.0.0.0 #255

Merged
merged 1 commit into from
Aug 28, 2024
Merged

OpenMetadata - Change default bind address to 0.0.0.0 #255

merged 1 commit into from
Aug 28, 2024

Conversation

tutte
Copy link
Contributor

@tutte tutte commented Aug 27, 2024 •
edited
Loading

What this PR does / why we need it :

This PR will replace the default binding host to be 0.0.0.0 instead of the hostname, which can lead to problems in kubernetes.
Fixes #256

Type of change :

  • Bug fix
  • Improvement
  • New feature
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name
  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • All new and existing tests passed.

Reviewers

@akash-jain-10

@nicor88
Copy link

nicor88 commented Aug 27, 2024

this fix address #256

@nicor88 nicor88 mentioned this pull request Aug 27, 2024
Closed
@tutte tutte merged commit 37b83a4 into main Aug 28, 2024
1 check failed
@tutte tutte deleted the hotfix-bind-k8s branch August 28, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akash-jain-10 akash-jain-10 akash-jain-10 approved these changes

@nicor88 nicor88 nicor88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change default openmetadata.config.openmetadata.host
3 participants
@tutte @nicor88 @akash-jain-10