Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: cron deploy pipelines #288

Merged
merged 10 commits into from
Dec 9, 2024
Merged

Feat: cron deploy pipelines #288

merged 10 commits into from
Dec 9, 2024

Conversation

tarunpandey23
Copy link
Contributor

What this PR does / why we need it :

Fixes #287

Ability to run Post Upgrade Steps for deploy-pipelines Kubernetes CronJob.

Type of change :

  • [ ] Bug fix
  • Improvement
  • New feature
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name
  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • All new and existing tests passed.

Reviewers

@tarunpandey23 tarunpandey23 mentioned this pull request Dec 5, 2024
Closed
3 tasks
akash-jain-10
akash-jain-10 requested changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@akash-jain-10 akash-jain-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution 👍🏼

Added some review comments which will make this better readable!

charts/openmetadata/values.yaml Show resolved Hide resolved
charts/openmetadata/values.yaml Outdated Show resolved Hide resolved
charts/openmetadata/values.schema.json Outdated Show resolved Hide resolved
charts/openmetadata/templates/_helpers.tpl Outdated Show resolved Hide resolved
akash-jain-10
akash-jain-10 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@akash-jain-10 akash-jain-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the contribution.

tutte
tutte approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@tutte tutte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution

@akash-jain-10 akash-jain-10 merged commit 956fc7a into open-metadata:main Dec 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akash-jain-10 akash-jain-10 akash-jain-10 approved these changes

@tutte tutte tutte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to run Post Upgrade Steps for deploy-pipelines and reindex as Kubernetes CronJob
3 participants
@tarunpandey23 @tutte @akash-jain-10