Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make APIs reactive #65

Merged
merged 12 commits into from
Oct 22, 2024
Merged

Make APIs reactive #65

merged 12 commits into from
Oct 22, 2024

Conversation

mbeckem
Copy link
Contributor

@mbeckem mbeckem commented Aug 17, 2024

No description provided.

Copy link

changeset-bot bot commented Aug 17, 2024

🦋 Changeset detected

Latest commit: 655b28b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor Author

@mbeckem mbeckem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I just found one minor issue. Also, please check changeset and documentation changes once for typos, there are a few misspellings of "reactivity" and "signals", for example.

this.#onPluginStateChanged(state);
},
{
immediate: true
Copy link
Contributor Author

@mbeckem mbeckem Aug 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Immediate is not necessary here. Removing it would keep the exact same behavior as before.

Copy link
Contributor

github-actions bot commented Oct 22, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-10-22 10:51 UTC

@arnevogt arnevogt marked this pull request as ready for review October 22, 2024 10:49
@arnevogt arnevogt merged commit 1ce5f11 into main Oct 22, 2024
12 checks passed
@mbeckem mbeckem deleted the feature/reactive-api branch October 22, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants