-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make APIs reactive #65
Conversation
🦋 Changeset detectedLatest commit: 655b28b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I just found one minor issue. Also, please check changeset and documentation changes once for typos, there are a few misspellings of "reactivity" and "signals", for example.
this.#onPluginStateChanged(state); | ||
}, | ||
{ | ||
immediate: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Immediate is not necessary here. Removing it would keep the exact same behavior as before.
|
No description provided.