Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search] Customizable placeholder #378

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

m-elseberg
Copy link
Contributor

This pull request allows the placeholder string displayed by the Search component to be specified as a prop (eliminating the need for an i18n override.)

The prop is yet to be documented in the package's README.md file.

Copy link

changeset-bot bot commented Nov 29, 2024

🦋 Changeset detected

Latest commit: 5d592c3

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 29, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://open-pioneer.github.io/trails-pr-previews/openlayers-base-packages/pr-previews/pr-378/
on branch gh-pages at 2024-11-29 14:13 UTC

Copy link
Contributor

@mbeckem mbeckem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Can you add a little bit of documentation and a changeset file?

src/packages/search/Search.tsx Outdated Show resolved Hide resolved
@mbeckem mbeckem merged commit 22a0e34 into open-pioneer:main Dec 2, 2024
7 checks passed
@m-elseberg m-elseberg deleted the search-placeholder branch December 2, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants